feat(store-sdk): custom events, tests and docs #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
September 6, 2021 13:22
…from unwrap function
|
✔️ Deploy Preview for storeui ready! 🔨 Explore the source changes: 500dfec 🔍 Inspect the deploy log: https://app.netlify.com/sites/storeui/deploys/613a41d19850d00007545cfc 😎 Browse the preview: https://deploy-preview-937--storeui.netlify.app |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 500dfec:
|
emersonlaurentino
requested changes
Sep 6, 2021
Co-authored-by: Emerson Laurentino <emersonlaurentino@hotmail.com>
lariciamota
reviewed
Sep 6, 2021
lariciamota
reviewed
Sep 6, 2021
Co-authored-by: Larícia Mota <laricia.mota@vtex.com.br>
Co-authored-by: Larícia Mota <laricia.mota@vtex.com.br>
emersonlaurentino
approved these changes
Sep 8, 2021
Gmantiqueira
pushed a commit
that referenced
this pull request
Sep 14, 2021
* fix: general wrapper types for analytics and removed unecessary code from unwrap function * chore: renaming analytics index file to wrap * chore: adding wrap and unwrap functions tests * chore: adding tests to analytics layer * feat: allows sending custom analytics events * feat: add docs to analytics * chore: add test for custom event * docs: adding link to GA4 spec * chore: removing tsdx incompatible code * fix: change title name to analytics * docs: correct grammar Co-authored-by: Emerson Laurentino <emersonlaurentino@hotmail.com> * docs: improve readability and fix erros on code Co-authored-by: Larícia Mota <laricia.mota@vtex.com.br> * chore: improve error message from useAnalyticsEvent Co-authored-by: Larícia Mota <laricia.mota@vtex.com.br> * chore: moving event samples to fixture file Co-authored-by: Emerson Laurentino <emersonlaurentino@hotmail.com> Co-authored-by: Larícia Mota <laricia.mota@vtex.com.br>
rrbambokian
pushed a commit
that referenced
this pull request
Sep 30, 2021
* fix: general wrapper types for analytics and removed unecessary code from unwrap function * chore: renaming analytics index file to wrap * chore: adding wrap and unwrap functions tests * chore: adding tests to analytics layer * feat: allows sending custom analytics events * feat: add docs to analytics * chore: add test for custom event * docs: adding link to GA4 spec * chore: removing tsdx incompatible code * fix: change title name to analytics * docs: correct grammar Co-authored-by: Emerson Laurentino <emersonlaurentino@hotmail.com> * docs: improve readability and fix erros on code Co-authored-by: Larícia Mota <laricia.mota@vtex.com.br> * chore: improve error message from useAnalyticsEvent Co-authored-by: Larícia Mota <laricia.mota@vtex.com.br> * chore: moving event samples to fixture file Co-authored-by: Emerson Laurentino <emersonlaurentino@hotmail.com> Co-authored-by: Larícia Mota <laricia.mota@vtex.com.br>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR adds tests and docs to analytics and changes the types so users are able to send and receive custom events as well.
How it works?
This PR adds a type called
UnknownEvent. It's the minimal event that can be sent viasendAnalyticsEvent. The suggestions for the AnalyticsEvent still happen, but users can override it with their own events by overriding the generic type on thesendAnalyticsEventfunction.