Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store-ui): enable non-relative imports #912

Closed
wants to merge 2 commits into from

Conversation

emersonlaurentino
Copy link
Member

@emersonlaurentino emersonlaurentino commented Aug 18, 2021

What's the purpose of this pull request?

#902

How it works?

How to test it?

References

@emersonlaurentino emersonlaurentino self-assigned this Aug 18, 2021
@emersonlaurentino emersonlaurentino requested a review from a team as a code owner August 18, 2021 21:45
@netlify
Copy link

netlify bot commented Aug 18, 2021

✔️ Deploy Preview for storeui ready!

🔨 Explore the source changes: b0e324d

🔍 Inspect the deploy log: https://app.netlify.com/sites/storeui/deploys/611d848d1a1aad00083e6570

😎 Browse the preview: https://deploy-preview-912--storeui.netlify.app

@emersonlaurentino emersonlaurentino changed the title feat(store-ui): enable non-relative imports WIP: feat(store-ui): enable non-relative imports Aug 18, 2021
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 565e0b9:

Sandbox Source
Store UI Typescript Configuration

@emersonlaurentino emersonlaurentino changed the title WIP: feat(store-ui): enable non-relative imports feat(store-ui): enable non-relative imports Aug 18, 2021
@@ -2,6 +2,7 @@
"extends": "@vtex/tsconfig",
"include": ["src"],
"compilerOptions": {
"baseUrl": "src",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add forceConsistentCasingInFileNames:true ? Since you're touchin on it?

@tlgimenes tlgimenes closed this Dec 6, 2021
@tlgimenes tlgimenes deleted the feat/non-relative-imports branch December 6, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants