Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storybook] General config and theme changes #776

Merged
merged 10 commits into from
Jun 19, 2021

Conversation

Gmantiqueira
Copy link
Contributor

@Gmantiqueira Gmantiqueira commented Jun 16, 2021

What's the purpose of this pull request?

  • Basic theme config with the VTEX brand color. In the future we can have a visual identity out of VTEX brand for our component library.
  • Title Storybook changes to StoreUI vX.X.X.
  • Adds a tab that shows the story code source, to see the entire implementation of the component.
  • Sort the stories list in this order: Getting Started > Atoms > Molecules > Organisms > Releases
  • Create a Releases section in our Storybook, with a Migration Guide and CHANGELOG templates.

@Gmantiqueira Gmantiqueira requested a review from a team as a code owner June 16, 2021 21:22
@netlify
Copy link

netlify bot commented Jun 16, 2021

✔️ Deploy Preview for storeui ready!

🔨 Explore the source changes: d8fabae

🔍 Inspect the deploy log: https://app.netlify.com/sites/storeui/deploys/60ce5a543c454d00070a902c

😎 Browse the preview: https://deploy-preview-776--storeui.netlify.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 16, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d8fabae:

Sandbox Source
Store UI Typescript Configuration

@tlgimenes
Copy link
Contributor

Somehow I'm getting the old storybook logo on the skeleton on the left when it's loading

@Gmantiqueira
Copy link
Contributor Author

Gmantiqueira commented Jun 16, 2021

Somehow I'm getting the old storybook logo on the skeleton on the left when it's loading

There's some cache or something that's annoying me. I'm trying to find out what's happening, thx.

It's blinking the old theme for a sec when I'm running locally.

@emersonlaurentino
Copy link
Member

Somehow I'm getting the old storybook logo on the skeleton on the left when it's loading

for me too

@Gmantiqueira Gmantiqueira changed the title [Storybook] Add theme, story code source and title WIP | [Storybook] Add theme, story code source and title Jun 17, 2021
@Gmantiqueira Gmantiqueira force-pushed the storybook/general-config branch from 0818378 to b397cbb Compare June 18, 2021 19:20
@Gmantiqueira Gmantiqueira changed the title WIP | [Storybook] Add theme, story code source and title [Storybook] Add theme, story code source and title Jun 18, 2021
@Gmantiqueira Gmantiqueira changed the title [Storybook] Add theme, story code source and title [Storybook] General config and theme changes Jun 18, 2021
}}
>
<h2 className="welcome__heading">Store Framework Jamstack</h2>
<h4 className="welcome__heading welcome__heading--subtitle">{`Store UI v${PackageInfo.version}`}</h4>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<h4 className="welcome__heading welcome__heading--subtitle">{`Store UI v${PackageInfo.version}`}</h4>
<h4 className="welcome__heading welcome__heading--subtitle">{`Store UI v${PackageInfo.version}. A complete, framework agnostic library for building your next digital experience`}</h4>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bold

Copy link
Contributor Author

@Gmantiqueira Gmantiqueira Jun 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@tlgimenes tlgimenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this? Will this change once we make a release?
image

@Gmantiqueira
Copy link
Contributor Author

Gmantiqueira commented Jun 18, 2021

What about this? Will this change once we make a release?
image

@tlgimenes Yeah, I put in there just for template and make it more easy when we start releasing stable versions. We can delete after the first version.

Copy link
Contributor

@tlgimenes tlgimenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AHTM!

@Gmantiqueira Gmantiqueira force-pushed the storybook/general-config branch from a5a2807 to d8fabae Compare June 19, 2021 20:57
@Gmantiqueira Gmantiqueira merged commit b99aee0 into master Jun 19, 2021
@Gmantiqueira Gmantiqueira deleted the storybook/general-config branch June 19, 2021 21:04
bentoper pushed a commit that referenced this pull request Jun 22, 2021
* Adding theme, story code source and title

* yarn.lock

* define normal as default theme

* adding URL and changing theme

* Changing storybook theme to be like VTEX

* Creating welcome page and sorting our stories

* Adding releases section and migration/changelog templates

* Releases section as last section in storybook

* welcome title removed

* editing Welcome content
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants