-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storybook] General config and theme changes #776
Conversation
✔️ Deploy Preview for storeui ready! 🔨 Explore the source changes: d8fabae 🔍 Inspect the deploy log: https://app.netlify.com/sites/storeui/deploys/60ce5a543c454d00070a902c 😎 Browse the preview: https://deploy-preview-776--storeui.netlify.app |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d8fabae:
|
Somehow I'm getting the old storybook logo on the skeleton on the left when it's loading |
There's some cache or something that's annoying me. I'm trying to find out what's happening, thx. It's blinking the old theme for a sec when I'm running locally. |
for me too |
0818378
to
b397cbb
Compare
}} | ||
> | ||
<h2 className="welcome__heading">Store Framework Jamstack</h2> | ||
<h4 className="welcome__heading welcome__heading--subtitle">{`Store UI v${PackageInfo.version}`}</h4> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<h4 className="welcome__heading welcome__heading--subtitle">{`Store UI v${PackageInfo.version}`}</h4> | |
<h4 className="welcome__heading welcome__heading--subtitle">{`Store UI v${PackageInfo.version}. A complete, framework agnostic library for building your next digital experience`}</h4> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bold
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emersonlaurentino Bold?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tlgimenes Yeah, I put in there just for template and make it more easy when we start releasing stable versions. We can delete after the first version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AHTM!
a5a2807
to
d8fabae
Compare
* Adding theme, story code source and title * yarn.lock * define normal as default theme * adding URL and changing theme * Changing storybook theme to be like VTEX * Creating welcome page and sorting our stories * Adding releases section and migration/changelog templates * Releases section as last section in storybook * welcome title removed * editing Welcome content
What's the purpose of this pull request?
Storybook
changes toStoreUI vX.X.X
.Getting Started
>Atoms
>Molecules
>Organisms
>Releases
Releases
section in our Storybook, with a Migration Guide and CHANGELOG templates.