Updating CONTRIBUTING.md #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…github bot that does that
|
✔️ Deploy Preview for storeui ready! 🔨 Explore the source changes: 613fac6 🔍 Inspect the deploy log: https://app.netlify.com/sites/storeui/deploys/60ca5f750a6a26000700e487 😎 Browse the preview: https://deploy-preview-775--storeui.netlify.app |
tlgimenes
approved these changes
Jun 16, 2021
CONTRIBUTING.MD
Outdated
| @@ -52,30 +52,27 @@ Example: | |||
|
|
|||
| 1. After acquiring the necessary approval, rebase and squash-merge your PR in master | |||
|
|
|||
| 2. Locally, go to the master branch pull the changes with `git pull origin master` | |||
| 2. A bot will commit on master releasing your changes. In the mean time, go grab a coffe ☕ | |||
There was a problem hiding this comment.
Typo: meantime and coffee
CONTRIBUTING.MD
Outdated
| 4. Go grab a coffe ☕ | ||
| > If the bot isn't working or you want to release it manually, use the following command to clean any artifact and release a clean build: | ||
| > | ||
| > `git clean -fdx && yarn && lerna run build && lerna publish minor --yes` |
There was a problem hiding this comment.
Is it ok to release minor version here?
CONTRIBUTING.MD
Outdated
| ``` | ||
| git rebase origin/master && git push --force | ||
| ``` | ||
|
|
||
| 8. Wait for the bots to approve the PR. | ||
| 6. Wait for the bots to approve the PR. |
There was a problem hiding this comment.
I would rewrite it to something like that,
Suggested change
| 6. Wait for the bots to approve the PR. | |
| 6. Wait for the PR checks to have been passed |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 613fac6:
|
igorbrasileiro
approved these changes
Jun 16, 2021
emersonlaurentino
approved these changes
Jun 16, 2021
afa6818 to
613fac6
Compare
bentoper
pushed a commit
that referenced
this pull request
Jun 17, 2021
* Removing release commands from contributing due to the addition of a github bot that does that * Improving grammar and changing release command to patch on the contributors guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR updates the CONTRIBUTING.md guide to not include the commands to release the application, since we have a bot that does that for us now.
I was following this guide and almost re-released the version I merged, so I think it would be good for contributors to have a disclaimer about the bot. Also, I think the command may still be useful, so I left it there with a disclaimer.