Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Removes url image as required field for Organization #2697

Merged
merged 1 commit into from
Feb 20, 2025
Merged

fix: Removes url image as required field for Organization #2697

merged 1 commit into from
Feb 20, 2025

Conversation

hellofanny
Copy link
Contributor

@hellofanny hellofanny commented Feb 20, 2025 •
edited
Loading

What's the purpose of this pull request?

  • Removes url as required field for Organization image.
  • The object should be optional, since might not be provided.
image

How to test it?

  • run vtex cms sync in the project.
  • when no image url provide no errors should appear.

@codesandbox-ci CodeSandbox CI
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@hellofanny hellofanny marked this pull request as ready for review February 20, 2025 16:47
@hellofanny hellofanny requested a review from a team as a code owner February 20, 2025 16:47
@hellofanny hellofanny requested review from emersonlaurentino, renatomaurovtex and eduardoformiga and removed request for a team February 20, 2025 16:47
@hellofanny hellofanny self-assigned this Feb 20, 2025
@hellofanny hellofanny merged commit f325a28 into main Feb 20, 2025
10 checks passed
@hellofanny hellofanny deleted the fix/seo-organization-image branch February 20, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduardoformiga eduardoformiga eduardoformiga approved these changes

@emersonlaurentino emersonlaurentino Awaiting requested review from emersonlaurentino emersonlaurentino is a code owner automatically assigned from vtex/faststore

@renatomaurovtex renatomaurovtex Awaiting requested review from renatomaurovtex renatomaurovtex is a code owner automatically assigned from vtex/faststore

Assignees

@hellofanny hellofanny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hellofanny @eduardoformiga