Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create composable AddReviewModal component #2693

Open
wants to merge 3 commits into
base: feat/reviews-and-ratings
Choose a base branch
from

Conversation

artursantiago
Copy link
Collaborator

@artursantiago artursantiago commented Feb 19, 2025

What's the purpose of this pull request?

This PR adds a new AddReviewModal component to the project's component package. The component follows the existing Modal component pattern and integrates with the UIProvider for state management.

How it works?

  • Adds a new AddReviewModal component with its compound components (Body and Footer)
  • Includes responsive styling for mobile devices through SCSS
  • Integrates the modal state management into UIProvider:
    • Adds addReviewModal boolean state
    • Adds openAddReviewModal and closeAddReviewModal actions
  • Modifies the base Modal component to handle transition state (fade in/out) through onTransitionEnd

How to test it?

  • Verify the modal's responsive behavior on mobile devices
  • Check that transitions work correctly when opening and closing the modal

Starters Deploy Preview

Preview

References

FEATURE BRANCH
Figma
SFS-2082

@artursantiago artursantiago mentioned this pull request Feb 19, 2025
2 tasks
@artursantiago artursantiago changed the title feat(AddReviewModal): create composable AddReviewModal component feat: create composable AddReviewModal component Feb 19, 2025
Copy link

codesandbox-ci bot commented Feb 19, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@Guilera Guilera force-pushed the feat/reviews-and-ratings branch from cc15cdd to 33db057 Compare February 19, 2025 17:34
@artursantiago artursantiago force-pushed the feat/add-review-modal-ui branch from e6a5492 to 41bab0c Compare February 21, 2025 12:05
@artursantiago artursantiago self-assigned this Feb 21, 2025
@artursantiago artursantiago added the enhancement New feature or request label Feb 21, 2025
@artursantiago artursantiago marked this pull request as ready for review February 21, 2025 12:31
@artursantiago artursantiago requested a review from a team as a code owner February 21, 2025 12:31
@artursantiago artursantiago requested review from hellofanny and eduardoformiga and removed request for a team February 21, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant