feat: empty search with global sections #2690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
pedromtec
approved these changes
Feb 18, 2025
lariciamota
approved these changes
Feb 18, 2025
the customization remains as it is nowadays: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR aims to wrap the EmptySearch with the Render sections so that this page state can have GlobalSections.
How to test it?
You can test this PR locally, see a search page without results, or use the preview link.
Starters Deploy Preview
PR
https://storeframework-cm652ufll028lmgv665a6xv0g-a6ylykbgr.b.vtex.app/s?q=sdafasdhflsdfhsda&fuzzy=auto&operator=or&facets=fuzzy%2Coperator&sort=score_desc&page=0
References
https://vtex.slack.com/archives/C051B6LL91U/p1739734780585179