feat: add reviews count to ProductTitle component #2655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
88b85e9 to
7518315
Compare
9c2cebb to
736e0f8
Compare
622b56f to
3ab33ce
Compare
Guilera
approved these changes
Feb 19, 2025
cc15cdd to
33db057
Compare
3ab33ce to
5999074
Compare
pedromtec
approved these changes
Feb 19, 2025
pedromtec
reviewed
Feb 19, 2025
packages/components/src/molecules/ProductTitle/ProductTitle.tsx
Outdated
Show resolved
Hide resolved
lariciamota
reviewed
Feb 19, 2025
packages/components/src/molecules/ProductTitle/ProductTitle.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/molecules/ProductTitle/ProductTitle.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/molecules/ProductTitle/ProductTitle.tsx
Outdated
Show resolved
Hide resolved
packages/core/src/components/sections/ProductDetails/ProductDetails.tsx
Outdated
Show resolved
Hide resolved
hellofanny
reviewed
Feb 20, 2025
packages/components/src/molecules/ProductTitle/ProductTitle.tsx
Outdated
Show resolved
Hide resolved
hellofanny
reviewed
Feb 20, 2025
hellofanny
reviewed
Feb 20, 2025
hellofanny
reviewed
Feb 20, 2025
hellofanny
reviewed
Feb 20, 2025
hellofanny
reviewed
Feb 20, 2025
Co-authored-by: Larícia Mota <laricia.mota@vtex.com.br>
Co-authored-by: Fanny Chien <fanny.chien@vtex.com>
Co-authored-by: Fanny Chien <fanny.chien@vtex.com>
Co-authored-by: Fanny Chien <fanny.chien@vtex.com>
Co-authored-by: Fanny Chien <fanny.chien@vtex.com>
Co-authored-by: Fanny Chien <fanny.chien@vtex.com>
lariciamota
reviewed
Feb 20, 2025
packages/core/src/components/sections/ProductDetails/ProductDetails.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Larícia Mota <laricia.mota@vtex.com.br>
hellofanny
reviewed
Feb 20, 2025
| {ratingValue !== undefined && <Rating value={ratingValue} />} | ||
|
|
||
| {reviewsCount !== undefined && ( | ||
| <a href="#reviews-and-ratings" data-fs-product-title-reviews> |
There was a problem hiding this comment.
just double checking that this is the fixed id, right?
hellofanny
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
Adds the number of reviews next to the Rating component in the ProductTitle. The review count, as well as the rating, should only be visible if the corresponding flag in the discovery.config is enabled in the code.
How it works?
The following props have been added to ProductTitle:
The review count text should be a link to the reviews section, which will be located further down on the product page. This link will receive the section ID through the reviewsSectionId prop. The labels for the text can also be customized via props, but by default, they will be "No reviews yet" and "X reviews."
How to test it?
You can access the preview link and open any pdp. It already should be able to show the reviews count for the product.
If the count label don't appear you can run
yarn cms-syncin thestart.storebranchStarters Deploy Preview
Preview
References
JIRA TASK: SFS-2064
Figma