feat: add rating field #2636
Merged
feat: add rating field #2636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hellofanny
reviewed
Feb 4, 2025
hellofanny
reviewed
Feb 4, 2025
87776b2 to
fee26d8
Compare
|
I just fixed the preview link. You can test it now. |
hellofanny
requested changes
Feb 7, 2025
| @@ -22,6 +22,7 @@ | |||
| // -------------------------------------------------------- | |||
| // Structural Styles | |||
| // -------------------------------------------------------- | |||
|
|
|||
There was a problem hiding this comment.
todo: fix the button size, it's currently 48px, and should be 32px.
I will suggest adding a new token:
// Button
--fs-rating-button-min-height: var(--fs-spacing-5);
and then on line 34, force the size:
[data-fs-rating-button] {
--fs-button-small-min-height: var(--fs-rating-button-min-height);
There was a problem hiding this comment.
Alright, I've implemented the suggested change, I had previously kept the token value because I thought it was something set for accessibility, so as not to make the touch area so small
There was a problem hiding this comment.
Actually, it is! In this case, I believe the design team considers 24px as the minimum target size. @renatamottam
2 tasks
artursantiago
added a commit
that referenced
this pull request
Feb 14, 2025
>⚠️ THIS PR DEPENDS ON [PR#2635](#2635)⚠️ ## What's the purpose of this pull request? This pull request adds the RatingField component, which will initially be used in the modal for adding reviews to a product. ## How it works? This PR creates a new molecule component called `RatingField`. In addition to the "input" fields for the actionable rating, it can also receive an `id`, `label`, and `error` via props to be displayed in the form. The component uses the `Rating` component with the `actionable` view, passing the `onChange` handler to it. ## How to test it? <!--- Describe the steps with bullet points. Is there any external link that can be used to better test it or an example? ---> ### Starters Deploy Preview <!--- Add a link to a deploy preview from `starter.store` with this branch being used. ---> <!--- Tip: You can get an installable version of this branch from the CodeSandbox generated when this PR is created. ---> [Preview](https://starter-git-feat-rating-field-vtex.vercel.app//review-and-ratings-playground) ## References [JIRA TASK: SFS-2078](https://vtex-dev.atlassian.net/browse/SFS-2078) [JIRA TASK: SFS-2077](https://vtex-dev.atlassian.net/browse/SFS-2077) [Figma](https://www.figma.com/design/YXU6IX2htN2yg7udpCumZv/Reviews-%26-Ratings?node-id=131-49445&t=iOanfcOwmDa4bolf-4)   --------- Co-authored-by: Fanny Chien <fanny.chien@vtex.com> Co-authored-by: Fanny Chien <fannychienn@gmail.com>
artursantiago
added a commit
that referenced
this pull request
Feb 14, 2025
>⚠️ THIS PR DEPENDS ON [PR#2635](#2635)⚠️ ## What's the purpose of this pull request? This pull request adds the RatingField component, which will initially be used in the modal for adding reviews to a product. ## How it works? This PR creates a new molecule component called `RatingField`. In addition to the "input" fields for the actionable rating, it can also receive an `id`, `label`, and `error` via props to be displayed in the form. The component uses the `Rating` component with the `actionable` view, passing the `onChange` handler to it. ## How to test it? <!--- Describe the steps with bullet points. Is there any external link that can be used to better test it or an example? ---> ### Starters Deploy Preview <!--- Add a link to a deploy preview from `starter.store` with this branch being used. ---> <!--- Tip: You can get an installable version of this branch from the CodeSandbox generated when this PR is created. ---> [Preview](https://starter-git-feat-rating-field-vtex.vercel.app//review-and-ratings-playground) ## References [JIRA TASK: SFS-2078](https://vtex-dev.atlassian.net/browse/SFS-2078) [JIRA TASK: SFS-2077](https://vtex-dev.atlassian.net/browse/SFS-2077) [Figma](https://www.figma.com/design/YXU6IX2htN2yg7udpCumZv/Reviews-%26-Ratings?node-id=131-49445&t=iOanfcOwmDa4bolf-4)   --------- Co-authored-by: Fanny Chien <fanny.chien@vtex.com> Co-authored-by: Fanny Chien <fannychienn@gmail.com>
artursantiago
added a commit
that referenced
this pull request
Feb 14, 2025
>⚠️ THIS PR DEPENDS ON [PR#2635](#2635)⚠️ ## What's the purpose of this pull request? This pull request adds the RatingField component, which will initially be used in the modal for adding reviews to a product. ## How it works? This PR creates a new molecule component called `RatingField`. In addition to the "input" fields for the actionable rating, it can also receive an `id`, `label`, and `error` via props to be displayed in the form. The component uses the `Rating` component with the `actionable` view, passing the `onChange` handler to it. ## How to test it? <!--- Describe the steps with bullet points. Is there any external link that can be used to better test it or an example? ---> ### Starters Deploy Preview <!--- Add a link to a deploy preview from `starter.store` with this branch being used. ---> <!--- Tip: You can get an installable version of this branch from the CodeSandbox generated when this PR is created. ---> [Preview](https://starter-git-feat-rating-field-vtex.vercel.app//review-and-ratings-playground) ## References [JIRA TASK: SFS-2078](https://vtex-dev.atlassian.net/browse/SFS-2078) [JIRA TASK: SFS-2077](https://vtex-dev.atlassian.net/browse/SFS-2077) [Figma](https://www.figma.com/design/YXU6IX2htN2yg7udpCumZv/Reviews-%26-Ratings?node-id=131-49445&t=iOanfcOwmDa4bolf-4)   --------- Co-authored-by: Fanny Chien <fanny.chien@vtex.com> Co-authored-by: Fanny Chien <fannychienn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This pull request adds the RatingField component, which will initially be used in the modal for adding reviews to a product.
How it works?
This PR creates a new molecule component called
RatingField. In addition to the "input" fields for the actionable rating, it can also receive anid,label, anderrorvia props to be displayed in the form. The component uses theRatingcomponent with theactionableview, passing theonChangehandler to it.How to test it?
Starters Deploy Preview
Preview
References
JIRA TASK: SFS-2078
JIRA TASK: SFS-2077
Figma