-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding organization structured data json #2623
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
8af705a
chore: Testing organization json
hellofanny 18244e2
feat: Adds organization seo info to discovery file
hellofanny dcdfe8d
chore: removes image field
hellofanny 7921d9f
feat: Adds organization fields to content type
hellofanny 6ebfe8e
feat: Using organization data
hellofanny ade9999
chore: Adds id, image and address attributes
hellofanny 45750d6
fix: adds missing brackets
hellofanny fd2412e
chore: Adds image and address country attr
hellofanny adc54e8
chore: Fixes attr descriptions
hellofanny 330a4cd
fix: Removes duplication
hellofanny 5723e20
chore: fix organization id
hellofanny 95ce17f
chore: Improves atributes descriptions
hellofanny 3d9e691
chore: Removing organization data from discovery, support only hcms data
hellofanny 994995e
chore: Adding organization structure only if available
hellofanny 221f7c5
chore: Updates fields descriptions
hellofanny 1eae4b5
chore: Adds url as required field
hellofanny 9ad2a22
chore: Adds address object if one of the attributes is available
hellofanny 1c0e35f
chore: refactoring to improve readability
hellofanny File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: what is this
id
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
id
serves as a reference key, allowing us to use it elsewhere in our structured data. Our client has listed it as a required attribute, as they seem to rely on it frequently.Maybe I should update this description 🙇
There is this link for reference.