-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding organization structured data json #2623
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
2362370
to
53e05f1
Compare
"type": "string", | ||
"default": "VTEX Commerce" | ||
}, | ||
"id": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: what is this id
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The id
serves as a reference key, allowing us to use it elsewhere in our structured data. Our client has listed it as a required attribute, as they seem to rely on it frequently.
Maybe I should update this description 🙇
There is this link for reference.
@@ -6,6 +6,30 @@ module.exports = { | |||
author: 'Store Framework', | |||
name: 'FastStore', | |||
publisherId: '', | |||
organization: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: I'm wondering, since it's already configurable in the hCMS, why add it also on the discovery.config? I understand there are already some SEO config on this file and on hCMS, but I started to wonder about it now because it's a lot of data and we are about to add more SEO data in upcoming PRs. So I'd like to hear what you thought about it, and if I'm missing something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice question! I just added it to follow the pattern, keeping it in both places and allowing customization via hCMS and code. However, I feel like we're adding more and more attributes. Maybe it would be better to create a separate file just for handling SEO configuration, or we could keep these "extra" settings in hCMS instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah!! Could you open a thread on our channel so everyone can discuss those approaches? 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've discussed as a team, and decided to keep particular page's SEO configurations only in the hCMS.
53e05f1
to
fd2412e
Compare
6d44df4
to
1c0e35f
Compare
What's the purpose of this pull request?
How it works?
Allow adding the following Organization schema proprieties:
Headless CMS
TODO: Run cms sync in default acc.
How to test it?
Organization
OR
storeframework
account, go to CMS admin, changes the fields values -> Save and Publish.organization
and validate the schema)Starters Deploy Preview
vtex-sites/starter.store#655
References