Feat: Adds tokens to Radio
#89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Creates Input Radio * Styles Radio * Adds Radio to Storybook * Adds tokens tables * Fixes Storybook table width * Fixes Checkbox hovers * Updates Changelog * Fix typo Co-authored-by: Fanny Chien <fannychienn@gmail.com> * Updates Checkbox Story to use TokenTable Co-authored-by: Fanny Chien <fannychienn@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Preview is readyThis pull request generated a Preview👀 Preview: https://sfj-898f27e--gatsby.preview.vtex.app |
Lighthouse ReportsHere are the Lighthouse reports of this Pull Request📝 Based on commit 898f27e
|
hellofanny
approved these changes
Jun 3, 2022
There was a problem hiding this comment.
Approving because It's working fine on the preview, and seems like all the changes made on https://github.com/vtex-sites/nextjs.store/pull/87 is also here.
Co-authored-by: Eduardo Formiga <eduardo.formiga@vtex.com.br>
eduardoformiga
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick from NextJS Project: https://github.com/vtex-sites/nextjs.store/pull/87
What's the purpose of this pull request?
This PR applies the new Theming structure to
Radio: new scoped tokens linked to global ones.Additionally, I updated Checkbox's hover state to follow Radio definitions.
How does it work?
This PR uses local variables to parameterize the
Radioproperties, then connects these scoped tokens to the global ones.See Story for full tokens documentation.
How to test it?
You can check the story on Storybook: Preview Link
Checklist
CHANGELOG.mdat the beginning of its due section. The latest version should comes first.CHANGELOG.md. E.g., New items in thepull_request_template.md(#4)Breaking change,Enhancement,BugorChore.ComponentNamecomponent.