From 9f94de00db4565c216317fb40e77be694d0e19e4 Mon Sep 17 00:00:00 2001 From: Emerson Laurentino Date: Thu, 24 Mar 2022 15:49:12 -0300 Subject: [PATCH 1/3] Update buttons.scss --- src/components/ui/Button/buttons.scss | 1 - 1 file changed, 1 deletion(-) diff --git a/src/components/ui/Button/buttons.scss b/src/components/ui/Button/buttons.scss index 52c02bef6..dff9f7bbb 100644 --- a/src/components/ui/Button/buttons.scss +++ b/src/components/ui/Button/buttons.scss @@ -17,7 +17,6 @@ text-decoration: none; column-gap: var(--fs-spacing-2); border: 0; - cursor: default; &:disabled, &[data-button-disabled="true"] { cursor: not-allowed; From cee3b26b67086b8aee91c21ffbe2b4d4bcd54030 Mon Sep 17 00:00:00 2001 From: Emerson Laurentino Date: Thu, 24 Mar 2022 15:54:28 -0300 Subject: [PATCH 2/3] Update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9b08946bb..8e97e44bc 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -81,6 +81,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Filter Button specificity on desktop - Filter facets are not being selected on mobile - `CartItem` image size and truncate long product's title +- Fix the button cursor ### Security From e8a864a916a9c006768d1ebd2023e91e85c44434 Mon Sep 17 00:00:00 2001 From: Emerson Laurentino Date: Fri, 25 Mar 2022 15:54:36 -0300 Subject: [PATCH 3/3] Apply suggestions from code review --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8e97e44bc..3b8ca6612 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -81,7 +81,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Filter Button specificity on desktop - Filter facets are not being selected on mobile - `CartItem` image size and truncate long product's title -- Fix the button cursor +- entrusting the definition of the cursor property to the browser ### Security