This repository has been archived by the owner on Jun 2, 2022. It is now read-only.
feat: Adds new Badge interactive variation #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Deploy Preview for basestore ready! 🔨 Explore the source changes: d0184ba 🔍 Inspect the deploy log: https://app.netlify.com/sites/basestore/deploys/623a1d0c6cc60100080369d1 😎 Browse the preview: https://deploy-preview-396--basestore.netlify.app |
Gatsby Cloud Build Reportbasestore 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 13m PerformanceLighthouse report
|
Preview is readyThis pull request generated a Preview👀 Preview: https://preview-396--base.preview.vtex.app |
heitorado
approved these changes
Mar 17, 2022
There was a problem hiding this comment.
I agree with @eduardoformiga review and suggestion - Apart from that, everything looks good 👍🏼
filipewl
approved these changes
Mar 17, 2022
ArthurTriis1
approved these changes
Mar 18, 2022
2451051 to
85eb18d
Compare
filipewl
approved these changes
Mar 21, 2022
b2380ae to
4ea8830
Compare
using as boolean instead
4ea8830 to
d0184ba
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR intends to add a new
Badgevariant calledinteractive. This will be useful when the user needs an action to close/remove badges.How does it work?
Default interactive badge:
Small interactive badge:
References
FSSS 204 - Creates Badge Interactive variation
Checklist