Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instability in the watch test: Windows #68

Closed
promiseofcake opened this issue Mar 13, 2018 · 4 comments
Closed

Instability in the watch test: Windows #68

promiseofcake opened this issue Mar 13, 2018 · 4 comments

Comments

@promiseofcake
Copy link
Contributor

Reported via @fruch in #65

there is some instability in the watch test (in windows it's failing constently)

We are not testing for Windows, an improvement would be to address that.

@fruch
Copy link
Contributor

fruch commented Mar 13, 2018

I have a bunch of fixes for windows I'll put them into a PR,
anyhow the instability I was refering too, was that it failed in the travis CI:
https://travis-ci.org/vsco/dcdr/builds/352241579?utm_source=github_status&utm_medium=notification

@fruch
Copy link
Contributor

fruch commented Mar 14, 2018

I think I've pined down the issue.

There two call to watch, one on New and one on Watch. there a lock on c.watcher.New() and also on c.watcher.Watch().

I'm a total newbie on golang, but seem like a race condition that makes the test pass on linux (and because fsnotify works different on windows, it's get stuck always, and the bug in the test is surfaced)

@fruch
Copy link
Contributor

fruch commented Mar 14, 2018

I think this change is the cause:
d8d6f27

@fruch
Copy link
Contributor

fruch commented May 14, 2018

I'm quite sure it's not windows only this issue, seen it fail on CI on #71 (rerun magicly solved it)

@promiseofcake promiseofcake closed this as not planned Won't fix, can't repro, duplicate, stale Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants