Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to tslint 5.1 #9

Closed
roman-petrov opened this issue Apr 18, 2017 · 7 comments
Closed

Update to tslint 5.1 #9

roman-petrov opened this issue Apr 18, 2017 · 7 comments

Comments

@roman-petrov
Copy link

Hello!

We are using these great rules in our project and seems that they are not compatible with TsLint 5.x release (maybe with 5.1 only...). Can you please update rules to latest TsLint ?

Many thanks!

@abdulmoizeng
Copy link

abdulmoizeng commented Apr 19, 2017

Few related issues fixed on following PR #8

@abierbaum
Copy link
Contributor

@roman-petrov I would love to get it updated to TSLint 5.x. I haven't had much time in the last month to work on it. Have you looking into what it would take?

@roman-petrov
Copy link
Author

roman-petrov commented Apr 21, 2017

@abierbaum I already tried to compile vrsource rules with TSLint 5.1 and got just a few compilation errors. Maybe i will try to make a PR in a few days if you don't mind. I didn't do that before because I currently have no experience working with forks on GitHub so I just need to get this basic knowledge :)

@abierbaum
Copy link
Contributor

I will see if I can make any progress on it today. I haven't looked closely at the API changes or if there is a straight forward way to update.

@roman-petrov
Copy link
Author

@abierbaum thank you very much. Please let me know if you find any issues migrating to tslint 5.1 that require time to R & D, i will be glad to spent my time to help

@abierbaum
Copy link
Contributor

@roman-petrov I just pushed up a new version that works with tslint 5.1. It didn't end up being as hard as I expected. Most of the issues were around the update to typescript 2.1

@roman-petrov
Copy link
Author

@abierbaum, thank you! Update works perfectly with tslint 5.1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants