Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests directory exported as top level package for elasticmock #12

Closed
jmlw opened this issue Jun 19, 2018 · 1 comment
Closed

tests directory exported as top level package for elasticmock #12

jmlw opened this issue Jun 19, 2018 · 1 comment

Comments

@jmlw
Copy link
Contributor

jmlw commented Jun 19, 2018

Tests is deployed and included in site-packages as a top level library as shown in the image below. This can cause errors when using frameworks like Serverless Framework where it attempts to symlink all top level site-packages into the root of your project directory if using the same folder structure. It seems it would be best practice to nest tests directory within the deployed package, or to exclude it from deployment.

Site packages in virtual environment:
image

@vrcmarcos
Copy link
Owner

I approved your PR (#13) and release v1.3.3.

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants