Does this reporter support the newest node version?

[raypettersen]

I'm getting a lot of errors scraping the .prom files using the new version of the node_exporter.

Example:

time="2017-03-23T12:57:35+01:00" level=error msg="error gathering metrics: 20 error(s) occurred:

• gathered metric family puppet_report_resources has help "Metric read from /etc/puppet/metrics/foo.prom" but should have "Metric read from /etc/puppet/metrics/bar.prom"

Note that the error involves two different prom files. It seems the first prom (alfabetically) actually succeeds, while everything else fails.

[raypettersen]

Is this project maintained? None of the other posts have any kind of interaction?

[marius-cotofana-hs]

Seems to be related to prometheus/node_exporter#485

A quick fix would be to add:

       file.write("# HELP puppet_report metric_help\n")
       metrics.each do |metric, data|
         file.write("# HELP puppet_report_#{metric} metric_help\n")
       end

to prometheus.rb line 71

[raypettersen]

So if I understand this correctly, the bug is in node, but a workaround in this reporter is possible with your suggestion?

[marius-cotofana-hs]

That's right.

[pugnacity]

@marius-cotofana-hs could you make a pull request for the workaround?

[oleg-glushak]

@pugnacity #22 This fix works for me.

[ldaneliukas]

Should this be closed as #22 was merged?

[ldaneliukas]

Verified running the reporter with node-exporter 0.16.0-8 - everything works as expected, this can be closed