You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@RafaelKa different transport providers have different constructors because they can have different dependencies. I see your point about using a url, but I can see circumstances where you may have a transport provider without a url - like a serial port provider.
I think it's best to let each transport provider implementation define it's own requirements, instead of trying to shoehorn them into a format that might not be conducive to that transport.
Why you can not define UART as URI?, just using comm://port_id;baudrate=9600;something=bla or comm://port_id?baudrate=9600&something=bla
With current API it is impossible to use UDS/TLS for RawSocket clients.
I think also, because RawSocket and Pawl providers using the same protocoll and same lib for low level layer ( also react/socket-client ), oth can get same API
Right now we are going to leave it up to the transports to decide what they need for construction. I would rather not develop new URI schemes as that is outside of the project scope. http://www.iana.org/assignments/uri-schemes/uri-schemes.xhtml
PawlTransportProvider
and RawSocketClientTransportProvider
have different constructors.
I would like to provide a PR for united API but i'm not sure which way is preferred by community.
Please note, that react/socket-client provides tls and UDS connections
as well ratchet/pawl provides secure web socket connection
So i think url way will be more robust:
for Pawl
Not sure but Pawl seems to support currently unix:// as well, because it uses Connector::create() method from react/socket-client
for RawSocket
Also i think that the RawSocketClientTransportProvider can be revised to give a way for similar api with Pawl.
PS: I provided PR for react/socket UDS support and psychoticmeow did similar for UDS but with BC break so if it is merged we can use UDS for router as well.
The text was updated successfully, but these errors were encountered: