From e6719223b992914ded5c54f935d4697d4fbb4e4b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michael=20Backenk=C3=B6hler?= Date: Wed, 26 Apr 2023 10:55:29 +0200 Subject: [PATCH 1/3] switch to linkinator --- .github/workflows/docs.yml | 27 +++++++++++++-------------- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml index f381fc13..d0ed1fff 100644 --- a/.github/workflows/docs.yml +++ b/.github/workflows/docs.yml @@ -61,20 +61,19 @@ jobs: shell: bash -l {0} run: | cd docs/_build/html - python -m http.server > /dev/null &2>1& - npx broken-link-checker http://localhost:8000/ --ordered --recursive \ - --exclude "*.txt" \ - --exclude "https://onlinelibrary.wiley.com/doi/full/10.1002/cmdc.200700139" \ - --exclude "https://onlinelibrary.wiley.com/doi/10.1002/9783527806539.*" \ - --exclude "https://towardsdatascience.com" \ - --exclude "https://medium.com" \ - --exclude "https://*.medium.com" \ - --exclude "http[s]://quora.com" \ - --exclude "http[s]://doi.org" \ - --exclude "ftp://*" \ - --exclude "http://localhost:8000" \ - --exclude "https://pubs.acs.org/doi/10.1021/acs.jcim.9b00662" \ - --exclude "https://pubs.acs.org/doi/abs/10.1021/bk-2021-1387.ch010" + npx linkinator . --recurse --timeout 5000 \ + -s "/*.txt" \ + -s "https://onlinelibrary.wiley.com/doi/full/10.1002/cmdc.200700139" \ + -s "https://onlinelibrary.wiley.com/doi/10.1002/9783527806539.*" \ + -s "https://towardsdatascience.com" \ + -s "https://medium.com" \ + -s "https://*.medium.com" \ + -s "http[s]://quora.com" \ + -s "http[s]://doi.org" \ + -s "ftp://*" \ + -s "http://localhost:8000" \ + -s "https://pubs.acs.org/doi/10.1021/acs.jcim.9b00662" \ + -s "https://pubs.acs.org/doi/abs/10.1021/bk-2021-1387.ch010" - name: Check 404s (README) uses: gaurav-nelson/github-action-markdown-link-check@v1 From 8441feadb8c1b43cede05775a1d381b77abcd621 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michael=20Backenk=C3=B6hler?= Date: Wed, 26 Apr 2023 11:01:18 +0200 Subject: [PATCH 2/3] no reason to exclude localhost:8000 --- .github/workflows/docs.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml index d0ed1fff..9c06ab2f 100644 --- a/.github/workflows/docs.yml +++ b/.github/workflows/docs.yml @@ -71,7 +71,6 @@ jobs: -s "http[s]://quora.com" \ -s "http[s]://doi.org" \ -s "ftp://*" \ - -s "http://localhost:8000" \ -s "https://pubs.acs.org/doi/10.1021/acs.jcim.9b00662" \ -s "https://pubs.acs.org/doi/abs/10.1021/bk-2021-1387.ch010" From 0e6f19175e5056d82fdde122206bb31fcfeef2d4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michael=20Backenk=C3=B6hler?= Date: Wed, 26 Apr 2023 13:01:07 +0200 Subject: [PATCH 3/3] tweak linkinator args --- .github/workflows/docs.yml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml index 9c06ab2f..f0365506 100644 --- a/.github/workflows/docs.yml +++ b/.github/workflows/docs.yml @@ -61,7 +61,7 @@ jobs: shell: bash -l {0} run: | cd docs/_build/html - npx linkinator . --recurse --timeout 5000 \ + npx linkinator . --verbosity error --recurse --timeout 5000 \ -s "/*.txt" \ -s "https://onlinelibrary.wiley.com/doi/full/10.1002/cmdc.200700139" \ -s "https://onlinelibrary.wiley.com/doi/10.1002/9783527806539.*" \ @@ -69,10 +69,9 @@ jobs: -s "https://medium.com" \ -s "https://*.medium.com" \ -s "http[s]://quora.com" \ - -s "http[s]://doi.org" \ + -s "http[s]://doi.org/*" \ + -s "http[s]://pubs.acs.org/*" \ -s "ftp://*" \ - -s "https://pubs.acs.org/doi/10.1021/acs.jcim.9b00662" \ - -s "https://pubs.acs.org/doi/abs/10.1021/bk-2021-1387.ch010" - name: Check 404s (README) uses: gaurav-nelson/github-action-markdown-link-check@v1