Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for the FlatBuffers API #312

Closed
ryzhyk opened this issue Aug 1, 2019 · 3 comments
Closed

Tests for the FlatBuffers API #312

ryzhyk opened this issue Aug 1, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@ryzhyk
Copy link
Contributor

ryzhyk commented Aug 1, 2019

No description provided.

@mihaibudiu mihaibudiu added the enhancement New feature or request label Aug 13, 2019
@ryzhyk
Copy link
Contributor Author

ryzhyk commented Sep 10, 2019

Some additional test dimensions:

  • Move type declarations into a module to test for namespace-related issues
  • Bit vectors >128 bit wide
  • Wrap various types in type aliases
  • Test user-defined generic types
  • Error handling (not just for flatbuf-related stuff):
    • commit/rollback without start should throw DDlogException
    • writing invalid DDlogRecord or DDlogRecord that does not match relation type should throw DDlogException
    • using invalid relation id in a command should throw DDlogException
    • inserting duplicate key or deleting non-existing key in a relation with primary key should throw DDlogException
    • attempt to reuse the same UpdateBuilder for more than one update should throw DDlogException
    • error messages should correctly identify the problem in each case

@mihaibudiu mihaibudiu self-assigned this Sep 13, 2019
@mihaibudiu
Copy link

I can work on some of these.

@ryzhyk
Copy link
Contributor Author

ryzhyk commented Sep 17, 2019

Thanks, that would be great! I'll push a PR soon and will switch to writing documentation. You can pick it up from there.

This was referenced Sep 20, 2019
@ryzhyk ryzhyk closed this as completed Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants