Skip to content
This repository has been archived by the owner on Jul 26, 2024. It is now read-only.

gs-validate too restrictive on docker check #168

Closed
thesnowdog opened this issue Feb 13, 2021 · 2 comments · Fixed by #164
Closed

gs-validate too restrictive on docker check #168

thesnowdog opened this issue Feb 13, 2021 · 2 comments · Fixed by #164
Assignees
Labels
enhancement New feature or request

Comments

@thesnowdog
Copy link

Issue Description
I am running the docker image cbcrowe/pihole-unbound and my container name is pihole. When validating that pihole runs in docker, gs-validate.sh seems to only look for “pihole/pihole” in the docker ps output. When I manually change that part of the script to “cbcrowe/pihole-unbound”, then sync works. Consider looking only for “pihole” when grepping the docker ps output.

@vmstan vmstan self-assigned this Feb 14, 2021
@vmstan vmstan added enhancement New feature or request investigation Issue is under investigation and removed investigation Issue is under investigation labels Feb 14, 2021
@vmstan vmstan linked a pull request Feb 14, 2021 that will close this issue
@vmstan
Copy link
Owner

vmstan commented Feb 14, 2021

So currently I have only been supporting the official Pi-hole container image. When I initially released it I didn't want to get bogged down with troubleshooting more than that. I still don't think I want this to be something I fully support yet, but I have added a variable called CONTAIMAGE which can be added in your gravity-sync.conf file. This will be available in 3.3.1 once I publish it.

CONTAIMAGE='cbcrowe/pihole-unbound'

Let me know if this works.

@thesnowdog
Copy link
Author

Works! Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants