Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trim the last spaces in the values of prisoners in quotes #234

Closed
ikee87 opened this issue May 31, 2017 · 3 comments
Closed

trim the last spaces in the values of prisoners in quotes #234

ikee87 opened this issue May 31, 2017 · 3 comments

Comments

@ikee87
Copy link

ikee87 commented May 31, 2017

Hi!
in file .env i have line

XI_SERVICE_PASSWORD="MY PASSWORD WHIT LAST SPACE "

In result i have string whit out last space... =( fix this.

https://github.com/vlucas/phpdotenv/blob/master/src/Loader.php#L257
@rgehan
Copy link

rgehan commented Aug 17, 2017 •
edited
Loading

Is this really bad behavior ?
Test cases in tests/Dotenv/DotenvTest.php seem to imply it is like this on purpose

@Korbeil
Copy link
Contributor

Korbeil commented May 19, 2018

Since it's explicit value between double quotes, it should not be trimed.

@Korbeil Korbeil mentioned this issue May 19, 2018
Closed
@GrahamCampbell
Copy link
Collaborator

GrahamCampbell commented Jan 2, 2019 •
edited
Loading

Trimming will be stopped in v3.0, implemented in #273. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rgehan @Korbeil @GrahamCampbell @ikee87