Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI/Build] Add bot to close stale issues and PRs #9436

Merged
merged 5 commits into from
Oct 23, 2024
Merged

[CI/Build] Add bot to close stale issues and PRs #9436

merged 5 commits into from
Oct 23, 2024

Conversation

russellb
Copy link
Member

@russellb russellb commented Oct 16, 2024 •
edited
Loading

This PR adds configuration to run the actions/stale github
action that closes stale issues and PRs.

Further discussion is on the issue.

Closes #9435

Signed-off-by: Russell Bryant rbryant@redhat.com

@russellb
[CI/Build] Add bot to close stale issues and PRs
4edea65 
This commit adds configuration to run the `actions/stale` github
action that closes stale issues and PRs.

Further discussion is in the issue.

Closes vllm-project#9435

Signed-off-by: Russell Bryant <rbryant@redhat.com>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@russellb russellb mentioned this pull request Oct 16, 2024
Closed
1 task
@hmellor
Copy link
Collaborator

hmellor commented Oct 17, 2024

This tutorial seems like a good template for us to use https://docs.github.com/en/actions/use-cases-and-examples/project-management/closing-inactive-issues

hmellor
hmellor requested changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very valuable PR for the health of the issue and pull request counters!

I've just left a few comments about word choices and removing a few lines that aren't 100% necessary.

@russellb @hmellor
Apply suggestions from code review
36a3979 
Apply suggested edits from @hmellor.

Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@russellb
Copy link
Member Author

This is a very valuable PR for the health of the issue and pull request counters!

I've just left a few comments about word choices and removing a few lines that aren't 100% necessary.

Thanks for the review! I applied all of the suggested edits except the one about the action reference (tag vs commit hash).

@russellb
ci: Fix syntax error after applying suggested edits from review
4290af0 
Signed-off-by: Russell Bryant <rbryant@redhat.com>
@russellb
stale: Ignore drafts and issues/prs with keep-open label
11caf27 
Signed-off-by: Russell Bryant <rbryant@redhat.com>
@russellb russellb marked this pull request as ready for review October 18, 2024 15:37
@russellb russellb requested review from hmellor and simon-mo October 18, 2024 15:38
@russellb @hmellor
Update .github/workflows/stale.yml
d70b50a 
Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@simon-mo simon-mo merged commit b548d7a into vllm-project:main Oct 23, 2024
31 checks passed
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
@russellb @Alvant
[CI/Build] Add bot to close stale issues and PRs (vllm-project#9436)
7d9fb11 
Signed-off-by: Alvant <alvasian@yandex.ru>
MErkinSag pushed a commit to MErkinSag/vllm that referenced this pull request Oct 26, 2024
@russellb
[CI/Build] Add bot to close stale issues and PRs (vllm-project#9436)
cb869eb 
Signed-off-by: Erkin Sagiroglu <erkin@infra-aipipeline-1-at1-prox-prod-a.ipa.corp.telnyx.com>
cooleel pushed a commit to cooleel/vllm that referenced this pull request Oct 28, 2024
@russellb @cooleel
[CI/Build] Add bot to close stale issues and PRs (vllm-project#9436)
7cb8366 
Signed-off-by: Shanshan Wang <shanshan.wang@h2o.ai>
cooleel pushed a commit to cooleel/vllm that referenced this pull request Oct 28, 2024
@russellb @cooleel
[CI/Build] Add bot to close stale issues and PRs (vllm-project#9436)
5eaab46 
Signed-off-by: Shanshan Wang <shanshan.wang@h2o.ai>
FerdinandZhong pushed a commit to FerdinandZhong/vllm that referenced this pull request Oct 29, 2024
@russellb @FerdinandZhong
[CI/Build] Add bot to close stale issues and PRs (vllm-project#9436)
7f2c9ec 
Signed-off-by: qishuai <ferdinandzhong@gmail.com>
NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Oct 31, 2024
@russellb @NickLucche
[CI/Build] Add bot to close stale issues and PRs (vllm-project#9436)
1c48022 
Signed-off-by: NickLucche <nlucches@redhat.com>
NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Oct 31, 2024
@russellb @NickLucche
[CI/Build] Add bot to close stale issues and PRs (vllm-project#9436)
cb1a358 
Signed-off-by: NickLucche <nlucches@redhat.com>
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
@russellb @sumitd2
[CI/Build] Add bot to close stale issues and PRs (vllm-project#9436)
2a06b85 
Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
@russellb
[CI/Build] Add bot to close stale issues and PRs (vllm-project#9436)
4fbe2fa
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 20, 2024
@russellb @mfournioux
[CI/Build] Add bot to close stale issues and PRs (vllm-project#9436)
09d1dc7 
Signed-off-by: Maxime Fournioux <55544262+mfournioux@users.noreply.github.com>
tlrmchlsmth pushed a commit to neuralmagic/vllm that referenced this pull request Nov 23, 2024
@russellb @tlrmchlsmth
[CI/Build] Add bot to close stale issues and PRs (vllm-project#9436)
7c92338 
Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmellor hmellor hmellor requested changes

@simon-mo simon-mo simon-mo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Enable stale bot for issues and PRs
3 participants
@russellb @hmellor @simon-mo