Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/Build] Add E2E tests for MLPSpeculator #5791

Merged
merged 7 commits into from
Jun 26, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adjust test to avoid precision issue in float16
Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com>
  • Loading branch information
tdoublep committed Jun 25, 2024
commit a96d11543a83f670df4a72ff0655c2dfe4dfaa02
6 changes: 3 additions & 3 deletions tests/spec_decode/e2e/test_mlp_correctness.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
MAX_SPEC_TOKENS = 5

# precision
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a note on why fp32?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have reverted fp32 change (does not fit in GPU memory).

PRECISION = "bfloat16"
PRECISION = "float16"


@pytest.mark.parametrize(
Expand Down Expand Up @@ -64,7 +64,7 @@
},
])
@pytest.mark.parametrize("output_len", [
256,
128,
])
@pytest.mark.parametrize("batch_size", [1, 32])
@pytest.mark.parametrize("seed", [1])
Expand Down Expand Up @@ -111,7 +111,7 @@ def test_mlp_e2e_greedy_correctness(baseline_llm_generator, test_llm_generator,
"output_len",
[
# Use small output len for fast test.
256,
128,
])
@pytest.mark.parametrize("batch_size", [4])
@pytest.mark.parametrize("seed", [1])
Expand Down