Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Revert "Add port number range validation" #13670

Conversation

terrytangyuan
Copy link
Contributor

@terrytangyuan terrytangyuan commented Feb 21, 2025

Reverts #13506

See #13506 (comment). It's not available in older versions of Python.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the frontend label Feb 21, 2025
…3506)"

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) February 21, 2025 13:45
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 21, 2025
@terrytangyuan terrytangyuan changed the title Revert "[API Server] Add port number range validation" [Bugfix] Revert "Add port number range validation" Feb 21, 2025
@Isotr0py
Copy link
Collaborator

#13672 should fix this issue, let's get it merged instead.

@Isotr0py Isotr0py disabled auto-merge February 21, 2025 14:41
@terrytangyuan terrytangyuan deleted the revert-13506-port-validate branch February 21, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants