Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API Server] Add port number range validation #13506

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

terrytangyuan
Copy link
Contributor

This PR adds validation on the range of the specified port number in API Server.

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the frontend label Feb 19, 2025
Copy link
Member

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @terrytangyuan!

@njhill njhill added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 19, 2025
@DarkLight1337 DarkLight1337 merged commit 3738e6f into vllm-project:main Feb 20, 2025
58 checks passed
@terrytangyuan terrytangyuan deleted the port-validate branch February 20, 2025 11:30
kerthcet pushed a commit to kerthcet/vllm that referenced this pull request Feb 21, 2025
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@WangErXiao
Copy link
Contributor

I found it doesn't work in Python 3.10

python3.10/argparse.py", line 1430, in add_argument
action = action_class(**kwargs)
TypeError: _StoreAction.init() got an unexpected keyword argument 'ge'

terrytangyuan added a commit to terrytangyuan/vllm that referenced this pull request Feb 21, 2025
terrytangyuan added a commit to terrytangyuan/vllm that referenced this pull request Feb 21, 2025
…3506)"

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan
Copy link
Contributor Author

I am reverting this in #13670 for now since Python 3.10 is gonna be around for a while: https://endoflife.date/python

@WangErXiao
Copy link
Contributor

I am reverting this in #13670 for now since Python 3.10 is gonna be around for a while: https://endoflife.date/python

OK, I just commit a pr #13672

@terrytangyuan
Copy link
Contributor Author

terrytangyuan commented Feb 21, 2025

I already sent it #13670. See my message above

@terrytangyuan
Copy link
Contributor Author

Thanks. Closed mine.

michaelrglass pushed a commit to michaelrglass/vllm that referenced this pull request Feb 21, 2025
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Michael Glass <mrglass@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants