-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API Server] Add port number range validation #13506
Conversation
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @terrytangyuan!
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
I found it doesn't work in Python 3.10 python3.10/argparse.py", line 1430, in add_argument |
…3506)" Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
I am reverting this in #13670 for now since Python 3.10 is gonna be around for a while: https://endoflife.date/python |
OK, I just commit a pr #13672 |
I already sent it #13670. See my message above |
Thanks. Closed mine. |
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: Michael Glass <mrglass@us.ibm.com>
This PR adds validation on the range of the specified port number in API Server.