Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Add missing license headers #12703

Closed
wants to merge 1 commit into from

Conversation

comaniac
Copy link
Collaborator

@comaniac comaniac commented Feb 3, 2025

Due to out of order merge #11330

cc @DarkLight1337 @mgoin @russellb @simon-mo

Signed-off-by: Cody Yu <hao.yu.cody@gmail.com>
Copy link

github-actions bot commented Feb 3, 2025

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@comaniac comaniac added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 3, 2025
@comaniac comaniac enabled auto-merge (squash) February 3, 2025 18:46
Copy link
Member

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@russellb
Copy link
Member

russellb commented Feb 3, 2025

This is also fixed by #12694

@comaniac
Copy link
Collaborator Author

comaniac commented Feb 3, 2025

I see. Then we should just merge that one ASAP and close this one.

@comaniac comaniac closed this Feb 3, 2025
auto-merge was automatically disabled February 3, 2025 18:53

Pull request was closed

@comaniac comaniac deleted the fix-license branch February 13, 2025 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants