Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1] Add logits_processors support #12688

Closed
wants to merge 11 commits into from

Conversation

imkero
Copy link
Contributor

@imkero imkero commented Feb 3, 2025

Add SamplingParams.logits_processors support for V1

Signed-off-by: imkero <kerorek@outlook.com>
Copy link

github-actions bot commented Feb 3, 2025

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the v1 label Feb 3, 2025
Signed-off-by: imkero <kerorek@outlook.com>
Signed-off-by: imkero <kerorek@outlook.com>
Signed-off-by: imkero <kerorek@outlook.com>
Signed-off-by: imkero <kerorek@outlook.com>
Signed-off-by: imkero <kerorek@outlook.com>
Signed-off-by: imkero <kerorek@outlook.com>
Signed-off-by: imkero <kerorek@outlook.com>
Signed-off-by: imkero <kerorek@outlook.com>
@imkero
Copy link
Contributor Author

imkero commented Feb 3, 2025

Maybe still some overhead near

parameters = inspect.signature(logits_processor).parameters

trying to enhance it

Signed-off-by: imkero <kerorek@outlook.com>
@imkero imkero requested a review from mgoin February 3, 2025 17:19
@njhill
Copy link
Member

njhill commented Feb 3, 2025

IMO we should take the V1 switch as an opportunity to change the design for logits processors. In particular I don't think we should support passing arbitrary LPs themselves per request (in SamplingParams) and rather be able to configure at startup time as plugins, which can consume custom request/sampling parameters.

Also I think we agreed that the interface should change to be stateful and work at a batch level (aligned with V1 persistent batch) so that vectorized implementations will be possible/encouraged by default.

@WoosukKwon
Copy link
Collaborator

+1 for @njhill's comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants