Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Model] Clean up MiniCPMV #10751

Merged
merged 9 commits into from
Nov 29, 2024
Merged

[Model] Clean up MiniCPMV #10751

merged 9 commits into from
Nov 29, 2024

Conversation

DarkLight1337
Copy link
Member

This PR cleans up the code of MiniCPMV, simplifying the weight loading code and removing the need to use LLMWrapper.

@DarkLight1337
Clean up MiniCPMV
fcc0d46 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 28, 2024
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Isotr0py
Isotr0py approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@Isotr0py Isotr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! Just have an idea about further cleanup.

@DarkLight1337
Fix tests
39b8fc3 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337
Fix typos
e0785a1 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337
Fix tests for MiniCPMV 2.6
b89b61a 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
mgoin
mgoin approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks so much for getting rid of LLMWrapper!

@DarkLight1337
Fix typo
ff3cc21 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337
Remove unused code
e847dee 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337
Copy link
Member Author

Somehow this breaks MiniCPMV 2.0, not sure why.

@DarkLight1337
Simplify _init_model
68e0b3d 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337
Copy link
Member Author

I fixed the problem - turns out scaling was incorrectly applied twice.

@DarkLight1337
Fix scaling and unnecessary casting
888e770 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 28, 2024 17:46
@ywang96
Copy link
Member

ywang96 commented Nov 29, 2024

@DarkLight1337 looks like it's breaking model loading

AttributeError: 'MiniCPM3Model' object has no attribute 'num_experts'

@DarkLight1337
Fix missing attribute
ebc54ee 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 merged commit fa6ecb9 into vllm-project:main Nov 29, 2024
47 of 48 checks passed
@DarkLight1337 DarkLight1337 deleted the cleanup-minicpmv branch November 29, 2024 04:54
afeldman-nm pushed a commit to neuralmagic/vllm that referenced this pull request Dec 2, 2024
@DarkLight1337 @afeldman-nm
[Model] Clean up MiniCPMV (vllm-project#10751)
170a30c 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Andrew Feldman <afeldman@neuralmagic.com>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@DarkLight1337
[Model] Clean up MiniCPMV (vllm-project#10751)
eff1747 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
@DarkLight1337 @BKitor
[Model] Clean up MiniCPMV (vllm-project#10751)
75178cd 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
anko-intel pushed a commit to HabanaAI/vllm-fork that referenced this pull request Feb 12, 2025
@DarkLight1337 @anko-intel
[Model] Clean up MiniCPMV (vllm-project#10751)
bd23cf8 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeejeelee jeejeelee jeejeelee left review comments

@Isotr0py Isotr0py Isotr0py approved these changes

@mgoin mgoin mgoin approved these changes

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DarkLight1337 @ywang96 @mgoin @jeejeelee @Isotr0py