Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Model]: Qwen2.5-Math-PRM-7B, Qwen2.5-Math-PRM-72B #12198

Closed
1 task done
HaitaoWuTJU opened this issue Jan 20, 2025 · 6 comments · Fixed by #12202
Closed
1 task done

[New Model]: Qwen2.5-Math-PRM-7B, Qwen2.5-Math-PRM-72B #12198

HaitaoWuTJU opened this issue Jan 20, 2025 · 6 comments · Fixed by #12202

Comments

@HaitaoWuTJU
Copy link

🚀 The feature, motivation and pitch

Qwen/Qwen2.5-Math-RM-72B has been supported.
New PRM model: Qwen2.5-Math-PRM-7B, Qwen2.5-Math-PRM-72B are not supported.

Image

Alternatives

No response

Additional context

No response

Before submitting a new issue...

  • Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.
@HaitaoWuTJU
Copy link
Author

@DarkLight1337
Copy link
Member

Can you try passing --hf-overrides '{"architectures": ["Qwen2ForRewardModel"]}' to use the existing vLLM implementation?

@HaitaoWuTJU
Copy link
Author

model = "Qwen/Qwen2.5-Math-PRM-7B"
task = 'embedding'
hf_overrides = {"architectures": ["Qwen2ForRewardModel"]}
llm = LLM(model=model, task=task, tensor_parallel_size=4, hf_overrides=hf_overrides)

Image

@Isotr0py
Copy link
Collaborator

Seems that it's because of the num_labels in score layer, RM is 1, while PRM 2.

@DarkLight1337
Copy link
Member

Unfortunately it doesn't seem like their config has num_labels field. Maybe we have to provide this through hf_overrides and read this config value in our model implementation.

@DarkLight1337
Copy link
Member

DarkLight1337 commented Jan 20, 2025

Never mind, num_labels is defined correctly after loading AutoConfig.

Actually num_labels is set to 2 for both Qwen/Qwen2.5-Math-RM-72B and Qwen2.5-Math-PRM-7B, so we can't use this directly...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants