-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add make docker-build in Integration Testing #93
Comments
@kr11 Let's use [Feat] or something else instead. Let's reserve |
This is great suggestion. |
Summary
This issue proposes the addition of integration tests for the make docker-build command to enhance reliability and detect configuration errors early in the development cycle.
Motivation
Currently, our typical debugging processes involve using
make run
or debugging via GoLand. However, these methods have significant limitations:RBAC Exposure Issue: The
make run
command does not reveal issues related to Role-Based Access Control (RBAC). For example, a previous PR addressed this error abouthorizontalpodautoscalers
(PR #72). A similar bug will be addressed in the upcoming PR forpodautoscaler_controller - KPA
.Detection of Specific Build Issues: Certain problems, such as missing packages or inconsistencies between
go.mod
and the Dockerfile versions, only become apparent when runningmake docker-build
. An example of this was seen in Pull #92.These challenges underscore the need for a more robust testing process that can preemptively identify and address potential issues before deployment.
Proposed Change
Some potential ways to solve it include:
make docker-build
and run tests on every push or pull request to the main branch.Alternatives Considered
No response
The text was updated successfully, but these errors were encountered: