Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The current e2e tests are flaky #651

Open
Tracked by #698
Jeffwan opened this issue Feb 12, 2025 · 8 comments
Open
Tracked by #698

The current e2e tests are flaky #651

Jeffwan opened this issue Feb 12, 2025 · 8 comments
Labels
area/testing Issues or PRs related to testing priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.

Comments

@Jeffwan
Copy link
Collaborator

Jeffwan commented Feb 12, 2025

🐛 Describe the bug

Image

Steps to Reproduce

No response

Expected behavior

No response

Environment

No response

@Jeffwan Jeffwan added area/testing Issues or PRs related to testing priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Feb 12, 2025
@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Feb 13, 2025

this is kind of painful now. the job takes very long, eventually failed and it lots of runtime.

@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Feb 13, 2025

Image

@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Feb 13, 2025

@varungup90 If you have not started this issue, I will take it over.

@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Feb 13, 2025

Image

I can reproduce the issue on my end but my setup is not 100% same as kind setups. I run e2e against my mac for desktop directly. I will double check that part and come back to this issue

@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Feb 13, 2025

Image

@varungup90
Copy link
Collaborator

What is the rootcause?

@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Feb 14, 2025

Image

Image

Image

unexpected EOF is the last issue. It happens to miss one request.

@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Feb 14, 2025

Image
https://github.com/openai/openai-go?tab=readme-ov-file#retries

It actually retried up to 3 times for 500 like issues. However, seems last request is commonly lost, ends up seeing 401 unexpected EOF issues. It has been verified by checking the headers for coming requests

Image

This could be gateway extension problems. I do not know the root cause. One thing we can do is to disable retry for this case.

client := openai.NewClient(
	option.WithMaxRetries(0), // default is 2
)

@Jeffwan Jeffwan mentioned this issue Feb 26, 2025
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Issues or PRs related to testing priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Development

No branches or pull requests

2 participants