Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gateway should reject model if model doesn't exist #526

Closed
Jeffwan opened this issue Dec 13, 2024 · 3 comments
Closed

gateway should reject model if model doesn't exist #526

Jeffwan opened this issue Dec 13, 2024 · 3 comments
Assignees
@Jeffwan
Labels
area/gateway good first issue Good for newcomers help wanted Extra attention is needed kind/bug Something isn't working
Milestone
v0.2.0

Comments

@Jeffwan
Copy link
Collaborator

Jeffwan commented Dec 13, 2024

🐛 Describe the bug

I notice this problem in a testing. When I delete the pod, I notice it return 500 without additional error. Technically, it should be a 404.. it can not find the associate model.

image

Steps to Reproduce

No response

Expected behavior

No response

Environment

No response
@Jeffwan Jeffwan added kind/bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed area/gateway labels Dec 13, 2024
@Jeffwan Jeffwan added this to the v0.2.0 milestone Dec 13, 2024
@Jeffwan Jeffwan self-assigned this Dec 17, 2024
@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Dec 23, 2024

image

I just delete the model and try to send a request during the deletion but notice nothing returned.

@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Dec 23, 2024

  • Terminating
    image

  • Deleted
    image

Terminating part is ok, we should clean up the dict key as well.

@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Dec 23, 2024

terminating we should reject the request as well

image

@Jeffwan Jeffwan mentioned this issue Dec 23, 2024
Merged
@Jeffwan Jeffwan closed this as completed Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jeffwan Jeffwan

Labels
area/gateway good first issue Good for newcomers help wanted Extra attention is needed kind/bug Something isn't working
Projects
None yet
Milestone
v0.2.0
Development

No branches or pull requests
1 participant
@Jeffwan