Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the Lora controller - part3 #52

Closed
Jeffwan opened this issue Jul 28, 2024 · 2 comments · Fixed by #54
Closed

Implement the Lora controller - part3 #52

Jeffwan opened this issue Jul 28, 2024 · 2 comments · Fixed by #54
Assignees
@Jeffwan
Labels
area/lora kind/feature Categorizes issue or PR as related to a new feature.
Milestone
v0.1.0-rc.0

Comments

@Jeffwan
Copy link
Collaborator

Jeffwan commented Jul 28, 2024 •
edited
Loading

🚀 Feature Description and Motivation

Address #35

  1. condition state machine should be finished + correct phase
  2. instance list should be managed
  3. curl /v1/models to make sure model has been loaded and avoid duplicate status update

Use Case

No response

Proposed Solution

No response
@Jeffwan Jeffwan added area/lora kind/feature Categorizes issue or PR as related to a new feature. labels Jul 28, 2024
@Jeffwan Jeffwan added this to the v0.1.0-rc.0 milestone Jul 28, 2024
@Jeffwan Jeffwan mentioned this issue Jul 29, 2024
Merged
@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Jul 29, 2024

it still lack of enough tests and l will file a separate PR to cover it

@Jeffwan Jeffwan assigned varungup90, xieus and Jeffwan and unassigned varungup90 and xieus Jul 29, 2024
@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Jul 29, 2024

image

some keywords needs to be tuned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jeffwan Jeffwan

Labels
area/lora kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
v0.1.0-rc.0
Development

Successfully merging a pull request may close this issue.

[Core] Improve model adapter controller by handling existing resources vllm-project/aibrix
3 participants
@Jeffwan @varungup90 @xieus