Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SecretsUsedInArgOrEnv on building mock app. #483

Closed
zhangjyr opened this issue Dec 4, 2024 · 0 comments · Fixed by #487
Closed

SecretsUsedInArgOrEnv on building mock app. #483

zhangjyr opened this issue Dec 4, 2024 · 0 comments · Fixed by #487
Labels
area/heterogeneous kind/bug Something isn't working priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Milestone
v0.2.0

Comments

@zhangjyr
Copy link
Collaborator

zhangjyr commented Dec 4, 2024

🐛 Describe the bug

#477 Introduced an error that causes docker builder reports " - SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "HUGGINGFACE_TOKEN") (line 24)".

Steps to Reproduce

No response

Expected behavior

No response

Environment

No response
@zhangjyr zhangjyr mentioned this issue Dec 5, 2024
Merged
@Jeffwan Jeffwan added kind/bug Something isn't working priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. area/heterogeneous labels Dec 5, 2024
@Jeffwan Jeffwan added this to the v0.2.0 milestone Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/heterogeneous kind/bug Something isn't working priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging a pull request may close this issue.

[Bug] Avoid including sensitive info in Dockerfile ENV vllm-project/aibrix
2 participants
@zhangjyr @Jeffwan