Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect scalingstrategy in autoscaler #474

Closed
nwangfw opened this issue Dec 3, 2024 · 0 comments · Fixed by #475
Closed

Incorrect scalingstrategy in autoscaler #474

nwangfw opened this issue Dec 3, 2024 · 0 comments · Fixed by #475
Assignees

Comments

@nwangfw
Copy link
Collaborator

nwangfw commented Dec 3, 2024

🐛 Describe the bug

switch pa.Spec.ScalingStrategy {
case autoscalingv1alpha1.HPA:
	// initialize all kinds of autoscalers, such as KPA and APA.
	// TODO Currently, we initialize kpa with default config and allocate window with default length.
	//  We then reallocate window according to pa until UpdateScalingContext.
	//  it's not wrong, but we allocate window twice, to be optimized.
	autoScaler, err = scaler.NewKpaAutoscaler(0, &pa)

In the current pod autoscaler switching logics, we choose HPA but use KPA inside. It should be KPA in the case selection.

Steps to Reproduce

No response

Expected behavior

No response

Environment

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant