Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current components separation still share same leader role. #449

Closed
Jeffwan opened this issue Nov 29, 2024 · 2 comments
Closed

Current components separation still share same leader role. #449

Jeffwan opened this issue Nov 29, 2024 · 2 comments
Assignees
@Jeffwan
Labels
area/installation kind/bug Something isn't working priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Milestone
v0.2.0

Comments

@Jeffwan
Copy link
Collaborator

Jeffwan commented Nov 29, 2024

🐛 Describe the bug

image

Steps to Reproduce

No response

Expected behavior

No response

Environment

No response
@Jeffwan Jeffwan self-assigned this Nov 29, 2024
@Jeffwan Jeffwan added kind/bug Something isn't working priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. area/installation labels Nov 29, 2024
@Jeffwan Jeffwan added this to the v0.2.0 milestone Nov 29, 2024
@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Nov 29, 2024

My careless, the main problem is we didn't distinguish the leader-election-id. Once it's specified per controller, it looks good.

flag.StringVar(&leaderElectionId, "leader-election-id", "aibrix-controller-manager",

@Jeffwan Jeffwan mentioned this issue Nov 29, 2024
Merged
@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Nov 30, 2024

I added --leader-election-id=aibrix-pod-autoscaler-controller in each controller manager and resolve this issue

@Jeffwan Jeffwan closed this as completed Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jeffwan Jeffwan

Labels
area/installation kind/bug Something isn't working priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
v0.2.0
Development

No branches or pull requests
1 participant
@Jeffwan