Some stateful PA attributes cannot be refreshed in reconcile #410
Labels
area/autoscaling
kind/enhancement
New feature or request
priority/critical-urgent
Highest priority. Must be actively worked on as someone's top priority right now.
Milestone
🐛 Describe the bug
Related to #406 and #409
We discovered that some parameters in KPA are stateful, such as the three parts of KPAScaler:
panic_window
,stable_window
, anddelay_windows
. These three parts are initialized in newReconciler only once, and won't be changed inreconcile
.The
reconcile()
function updates theKpaScalingContext
periodically but does not refresh these three parts. As a result,apply -f pa.yaml
may fail to take effect on these stateful parameters.Let's think a complex situation:
kpa.yaml
by setting stable_duration to 10s and apply it again, should controller discard the extra metrics?Steps to Reproduce
No response
Expected behavior
No response
Environment
No response
The text was updated successfully, but these errors were encountered: