Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seems Httproute not in aibrix-system won't work #336

Closed
Jeffwan opened this issue Oct 27, 2024 · 8 comments
Closed

Seems Httproute not in aibrix-system won't work #336

Jeffwan opened this issue Oct 27, 2024 · 8 comments
Assignees
Labels
area/gateway event/bugbash issues reported at bug bash
Milestone

Comments

@Jeffwan
Copy link
Collaborator

Jeffwan commented Oct 27, 2024

🐛 Describe the bug

image

Steps to Reproduce

No response

Expected behavior

No response

Environment

No response

@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Oct 27, 2024

gateway part should have namespace fix to aibrix-system, otherwise, it think the namespace should be same as HTTPRoute

@Jeffwan Jeffwan added this to the v0.1.0-rc.5 milestone Oct 29, 2024
@Jeffwan Jeffwan added area/gateway event/bugbash issues reported at bug bash labels Oct 29, 2024
@varungup90
Copy link
Collaborator

Adding a fix to create referance grant to connect httproute (in aibrix-system namespace) and service if in another namespace. Right now httproute is created in same namespace as service but I am thinking, since it is gateway related object lets create it in our namespace (aibrix-system)

@varungup90
Copy link
Collaborator

#347

@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Nov 11, 2024

  1. I double checked v0.1.0-rc.4. I update the namespace with aibrix-system and it doesn't work, I may add some other grants etc in my earlier test. this is expected and approve the grant is needed here.
    image

  2. However, I build nightly image from main branch and notice the problem is gone.. this is weird. could you help reproduce it?

image

@varungup90
Copy link
Collaborator

For 2, on describing httproute there is no status. I think, it is using least-request as routing algorithm which does not need httproute.

Can you check env variable for gateway deployment and use -v option in curl request to print response header (it will have target-pod)

@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Nov 11, 2024

@varungup90 Got you. I listed the details. My point is nightly build is supposed not to work with empty strategy header.. why does it work now? It should not bypass httproute and use a pod direct strategy as backup?

image

curl -v http://localhost:8000/v1/chat/completions \
  -H "Content-Type: application/json" \
  -H "Authorization: Bearer any_key" \
  -d '{
     "model": "llama2-70b",
     "messages": [{"role": "user", "content": "Say this is a test!"}],
     "temperature": 0.7
   }'
* Host localhost:8000 was resolved.
* IPv6: ::1
* IPv4: 127.0.0.1
*   Trying [::1]:8000...
* Connected to localhost (::1) port 8000
> POST /v1/chat/completions HTTP/1.1
> Host: localhost:8000
> User-Agent: curl/8.7.1
> Accept: */*
> Content-Type: application/json
> Authorization: Bearer any_key
> Content-Length: 129
>
* upload completely sent off: 129 bytes
< HTTP/1.1 200 OK
< server: Werkzeug/3.0.6 Python/3.9.20
< date: Mon, 11 Nov 2024 18:37:29 GMT
< content-type: application/json
< content-length: 305
< x-went-into-resp-headers: true
< target-pod: 10.1.6.61:8000
<
{"choices":[{"finish_reason":"stop","index":0,"logprobs":null,"message":{"content":"\n\nThis is a test fromllama2-70b!","role":"assistant"}}],"created":1677858242,"id":"chatcmpl-abc123","model":"llama2-70b","object":"chat.completion","usage":{"completion_tokens":36,"prompt_tokens":61,"total_tokens":97}}
* Connection #0 to host localhost left intact

@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Nov 11, 2024

Synced with Varun offline, I forgot the env override on the deployment. that's why it bypass the httproute and start to work.

@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Nov 12, 2024

We determine to leave httproute in aibrix-system at this moment

@Jeffwan Jeffwan closed this as completed Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gateway event/bugbash issues reported at bug bash
Projects
None yet
Development

No branches or pull requests

2 participants