Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce expectation package to control the expected object counts to avoid duplication #162

Closed
Jeffwan opened this issue Sep 11, 2024 · 0 comments · Fixed by #164
Closed

Introduce expectation package to control the expected object counts to avoid duplication #162

Jeffwan opened this issue Sep 11, 2024 · 0 comments · Fixed by #164
Assignees
@Jeffwan
Labels
area/distributed kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@Jeffwan
Copy link
Collaborator

Jeffwan commented Sep 11, 2024

🚀 Feature Description and Motivation

This would be helpful in the pod or any resource creation/deletion. Since pod start up takes time, without expectation, reconcile loop may create duplicate objects. The tricky thing is expectation is not in the controller-runtime package. We need to get it from upstream.

Use Case

Use it to control the number of the raycluster we plan to create.

Proposed Solution

No response
@Jeffwan Jeffwan self-assigned this Sep 11, 2024
@Jeffwan Jeffwan added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/feature Categorizes issue or PR as related to a new feature. area/distributed labels Sep 11, 2024
@Jeffwan Jeffwan mentioned this issue Sep 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jeffwan Jeffwan

Labels
area/distributed kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add expectation lib to allows us to set and wait on expectations vllm-project/aibrix
1 participant
@Jeffwan