Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary Role and RoleRBAC permission from existing demos #142

Closed
Jeffwan opened this issue Sep 9, 2024 · 1 comment
Closed

Remove unnecessary Role and RoleRBAC permission from existing demos #142

Jeffwan opened this issue Sep 9, 2024 · 1 comment
Labels
area/installation kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Milestone
v0.1.0-rc.2

Comments

@Jeffwan
Copy link
Collaborator

Jeffwan commented Sep 9, 2024

🚀 Feature Description and Motivation

https://github.com/aibrix/aibrix/blob/daf89f4af6f7b51f1ab3814a1dba999303801a65/docs/development/app/deployment.yaml#L75-L118

this should be removed. If any pod need pod/deployment list permissions, we should create them along with that component instead of manipulating the default service account

Use Case

No response

Proposed Solution

No response
@Jeffwan Jeffwan added this to the v0.1.0-rc.2 milestone Sep 9, 2024
@Jeffwan Jeffwan added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/installation labels Sep 9, 2024
@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Sep 17, 2024

It has been addressed in #143 and we can close it now.

@Jeffwan Jeffwan closed this as completed Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/installation kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
v0.1.0-rc.2
Development

No branches or pull requests
1 participant
@Jeffwan