Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the verify-codegen.sh into CI pipeline #131

Closed
Jeffwan opened this issue Sep 5, 2024 · 1 comment
Closed

Add the verify-codegen.sh into CI pipeline #131

Jeffwan opened this issue Sep 5, 2024 · 1 comment
Assignees
Labels
area/cicd area/tools kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@Jeffwan
Copy link
Collaborator

Jeffwan commented Sep 5, 2024

🚀 Feature Description and Motivation

We should add ./hack/verify-codegen.sh to the CI pipeline, if there's any API spec change, we should generate the clientset in the same PR.

before we add to the pipeline, we need to resolve an issue

Seems it tries to delete the zz_generated.deepcopy.go file which conflicts with make generate. We need to adjust update-codegen.sh to address such issue.
image

Use Case

No response

Proposed Solution

No response

@Jeffwan Jeffwan added kind/feature Categorizes issue or PR as related to a new feature. area/cicd area/tools labels Sep 5, 2024
@Jeffwan Jeffwan added this to the v0.1.0-rc.1 milestone Sep 5, 2024
@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Sep 6, 2024

#132 add to the CI pipeline and we can close this issue

@Jeffwan Jeffwan closed this as completed Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cicd area/tools kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants