Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debounce should support multi instances #145

Closed
Shemesh opened this issue Jul 7, 2022 · 3 comments
Closed

debounce should support multi instances #145

Shemesh opened this issue Jul 7, 2022 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Shemesh
Copy link

Shemesh commented Jul 7, 2022

hi,
the debounce decorator does not support multi instances.
plz read this article - https://engineering.datorama.com/be-aware-of-the-debounce-decorator-6fb24a6d8d5
and here is the solution -https://github.com/NetanelBasal/helpful-decorators/blob/master/src/debounce.ts

@vlio20
Copy link
Owner

vlio20 commented Jul 10, 2022

@Shemesh would you mind submitting a PR?

@vlio20
Copy link
Owner

vlio20 commented Jul 15, 2022

The issue reproduced on stackblitz:
https://angular-3bpkw9.stackblitz.io

@vlio20 vlio20 self-assigned this Jul 16, 2022
@vlio20 vlio20 added the bug Something isn't working label Jul 16, 2022
@vlio20 vlio20 added this to the 2.0.5 milestone Jul 16, 2022
@vlio20
Copy link
Owner

vlio20 commented Jul 16, 2022

Will be available in 2.0.5
fixed in #146

@vlio20 vlio20 closed this as completed Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants