Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type alias looses unsigned integer negative value check at compile time #22868

Closed
khalyomede opened this issue Nov 15, 2024 · 0 comments · Fixed by #22871
Closed

Type alias looses unsigned integer negative value check at compile time #22868

khalyomede opened this issue Nov 15, 2024 · 0 comments · Fixed by #22871
Labels
Bug This tag is applied to issues which reports bugs.

Comments

@khalyomede
Copy link
Contributor

khalyomede commented Nov 15, 2024

Describe the bug

When a struct expects a type alias that is a unsigned integer, the compiler will let the code pass, when using a primitive unsigned integer type will not compile.

Reproduction Steps

This code will pass compilation:

module main

type Port = u16

struct App {
    port Port
}

fn main() {
    app := App{
        port: -1
    }
}

When this code will produce an error:

module main

struct App {
    port u16
}

fn main() {
    app := App{
        port: -1
    }
}
error: cannot assign negative value to unsigned integer type
    9 | fn main() {
   10 |     app := App{
   11 |         port: -1
      |               ~~
   12 |     }

Expected Behavior

To have an error when the first snippet code is compiled.

Current Behavior

No compilation error.

Possible Solution

No response

Additional Information/Context

No response

V version

0.4.7 e03bd3f

Environment details (OS name and version, etc.)

V full version: V 0.4.7 e03bd3f
OS: linux, Linux version 6.8.0-48-generic (buildd@lcy02-amd64-040) (x86_64-linux-gnu-gcc-12 (Ubuntu 12.3.0-1ubuntu122.04) 12.3.0, GNU ld (GNU Binutils for Ubuntu) 2.38) #4822.04.1-Ubuntu SMP PREEMPT_DYNAMIC Mon Oct 7 11:24:13 UTC 2
Processor: 8 cpus, 64bit, little endian, Intel(R) Core(TM) i7-10510U CPU @ 1.80GHz

getwd: /home/v
vexe: /opt/vlang/v
vexe mtime: 2024-09-26 07:47:51

vroot: OK, value: /opt/vlang
VMODULES: OK, value: /root/.vmodules
VTMP: OK, value: /tmp/v_0

env VFLAGS: "-cc gcc"

Git version: git version 2.40.3
Git vroot status: e03bd3f (398 commit(s) behind V master)
.git/config present: true

CC version: cc (Alpine 12.2.1_git20220924-r10) 12.2.1 20220924
thirdparty/tcc status: thirdparty-linuxmusl-amd64 a3e24da2

Note

You can use the 👍 reaction to increase the issue's priority for developers.

Please note that only the 👍 reaction to the issue itself counts as a vote.
Other reactions and those to comments will not be taken into account.

Huly®: V_0.6-21311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This tag is applied to issues which reports bugs.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant