Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow
use
tag in SVG againuse
can be used to define paths once in a SVG and then integrating them multiple times via anchor links:<use xlink:href="#path-id" />
. This should not be prohibited.Banning
use
caused problems for one of our clients when uploading SVGs because they use the pattern described above.It's still not possible to use
use
to reference external files, since we still prohibithref
andxlink:href
attributes starting withhttp://
,https://
andjavascript:
.Also fix a typing problem that lead to a type error in useDamFileUpload. This caused no error message to show up in the Admin when uploading a bad SVG. Instead, the upload progress bar was shown forever.
Acceptance criteria
Screenshots/screencasts
Before:
Bildschirmaufnahme.2025-02-27.um.09.31.03.mov
Now:
Bildschirmaufnahme.2025-02-27.um.09.30.39.mov
Further information