Demo API: Remove mikro-orm:* scripts
#3515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the `mikro-orm:drop` and `mikro-orm:migration:generate` from api/package.json scripts. As alternative simply use the mikro-orm script: - `npx run mikro-orm --help` - `npx run mikro-orm schema:drop --run` - `npx run mikro-orm migration:create` Why remove? - `mikro-orm:migration:generate`'s naming is still coming from type-orm I suppose - why should abritary commands get it's own script? Why keep? - those two are the commonly used commands - devs are used to it
3 tasks
johnnyomair
previously approved these changes
Feb 26, 2025
dkarnutsch
previously approved these changes
Feb 26, 2025
nsams
commented
Feb 26, 2025
oh, I wasn't aware of that. we don't need all the reviewers then. |
johnnyomair
reviewed
Feb 26, 2025
| @@ -17,9 +17,6 @@ | |||
| "lint:prettier": "npx prettier --check './**/*.{js,json,md,yml,yaml}'", | |||
| "lint:tsc": "tsc --project ./tsconfig.lint.json", | |||
| "lint:generated-files-not-modified": "$npm_execpath api-generator && git diff --exit-code HEAD -- src/**/generated", | |||
| "mikro-orm": "mikro-orm", | |||
There was a problem hiding this comment.
This will be needed again in next due to MikroORM v6, we (i.e. I 😁) should consider this when merging main into next.
mikro-orm scripts
mikro-orm scriptsmikro-orm:* scripts
johnnyomair
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
mikro-orm,mikro-orm:dropandmikro-orm:migration:generatefrom api/package.json scripts.As alternative simply use the mikro-orm script:
npx mikro-orm --helpnpx mikro-orm schema:drop --runnpx mikro-orm migration:createWhy remove?
mikro-orm:migration:generate's naming is still coming from type-orm I supposeWhy keep?