Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve naming of CSpell user dictionary #3513

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Conversation

johnnyomair
Copy link
Collaborator

@johnnyomair johnnyomair commented Feb 25, 2025

Description

It wasn't clear for our devs that the project-words.txt file relates to the spell check. We therefore rename it to .cspellignore, which is in line with .gitignore, .eslintignore, etc. We also change the config file to .cspell.json so both files will be next to each other in the editor.

@johnnyomair johnnyomair added the needs-starter-pr Change in Demo that needs to be changed in Starter as well. label Feb 25, 2025
@johnnyomair johnnyomair self-assigned this Feb 25, 2025
@nsams nsams removed their request for review February 25, 2025 16:20
@johnnyomair johnnyomair removed the needs-starter-pr Change in Demo that needs to be changed in Starter as well. label Feb 25, 2025
@dkarnutsch
Copy link
Contributor

I'd add it to the start as well

@johnnyomair
Copy link
Collaborator Author

I'd add it to the start as well

Already done: vivid-planet/comet-starter#747.

@manuelblum
Copy link
Collaborator

I like it, way much more clear for me

@johnnyomair johnnyomair merged commit 9fa3b6f into main Feb 26, 2025
11 checks passed
@johnnyomair johnnyomair deleted the cspell-user-dictionary branch February 26, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants