Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge @comet/admin-theme into @comet/admin #3479

Merged
merged 9 commits into from
Feb 27, 2025

Conversation

jamesricky
Copy link
Contributor

@jamesricky jamesricky commented Feb 21, 2025

Description

This allows more flexibility for the theme like setting translatable text in defaultProps and using admin components.
An example use-case would be the localeText and custom Panel component used in DataGrid: #3033

Acceptance criteria

Open TODOs/questions

  • Add changeset

Further information

@jamesricky jamesricky self-assigned this Feb 21, 2025
@jamesricky jamesricky force-pushed the move-theme-into-admin-package branch from 402ae1a to fe48623 Compare February 21, 2025 13:25
@thomasdax98 thomasdax98 added this to the v8.0.0 milestone Feb 24, 2025
@jamesricky jamesricky force-pushed the move-theme-into-admin-package branch 2 times, most recently from 9bd4821 to 4e05222 Compare February 24, 2025 09:27
@jamesricky jamesricky changed the title Move admin-theme into the admin package Remove the @comet/admin-theme package and move it's content into @comet/admin Feb 24, 2025
@jamesricky jamesricky changed the title Remove the @comet/admin-theme package and move it's content into @comet/admin Remove the @comet/admin-theme package and move its content into @comet/admin Feb 24, 2025
@jamesricky jamesricky force-pushed the move-theme-into-admin-package branch 3 times, most recently from e591d3a to 3defad9 Compare February 25, 2025 09:56
@jamesricky jamesricky marked this pull request as ready for review February 25, 2025 14:31
Copy link
Collaborator

@johnnyomair johnnyomair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a section in the migration guide.

jamesricky and others added 5 commits February 26, 2025 15:09
Co-authored-by: Johannes Obermair <48853629+johnnyomair@users.noreply.github.com>
Co-authored-by: Johannes Obermair <48853629+johnnyomair@users.noreply.github.com>
@jamesricky jamesricky changed the title Remove the @comet/admin-theme package and move its content into @comet/admin Merge @comet/admin-theme into @comet/admin Feb 26, 2025
As it's already a dependency of `@mui/material`.
@johnnyomair johnnyomair merged commit 717ede6 into next Feb 27, 2025
12 checks passed
@johnnyomair johnnyomair deleted the move-theme-into-admin-package branch February 27, 2025 07:42
@thomasdax98 thomasdax98 modified the milestones: v8.0.0, v8-beta Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants