Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent internal sx of Button from being overridden #3470

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Prevent internal sx of Button from being overridden #3470

merged 2 commits into from
Feb 25, 2025

Conversation

jamesricky
Copy link
Contributor

Description

Previously, when passing an sx prop to a Button, that sx prop would fully replace the sx prop defined by the button internally, in variantToMuiProps.

Acceptance criteria

@jamesricky
Prevent internal sx of Button from being overridden
0429369 
Previously, when passing an `sx` prop to a `Button`, that `sx` prop
would fully replace the `sx` prop defined by the button internally, in
`variantToMuiProps`.
@jamesricky jamesricky self-assigned this Feb 19, 2025
@jamesricky @johnnyomair
Improve changeset
561056c 
Co-authored-by: Johannes Obermair <48853629+johnnyomair@users.noreply.github.com>
@johnnyomair johnnyomair merged commit 6827982 into main Feb 25, 2025
11 checks passed
@johnnyomair johnnyomair deleted the fix-button-sx-of-variant branch February 25, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnyomair johnnyomair johnnyomair approved these changes

Assignees

@jamesricky jamesricky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesricky @johnnyomair